Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backend supports for tso and scheduling #1648

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Add backend supports for tso and scheduling #1648

merged 2 commits into from
Mar 14, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 21, 2024 •
edited
Loading

The component name might be changed later. Ref #1651

@ti-chi-bot ti-chi-bot bot requested a review from Renkai February 21, 2024 06:45
@CLAassistant
Copy link

CLAassistant commented Feb 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XXL label Feb 21, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 21, 2024 •
edited
Loading

✅ Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit a86edef
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/65f2890ff9e3b40008e95afc
😎 Deploy Preview https://deploy-preview-1648--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 3.42466% with 282 lines in your changes are missing coverage. Please review.

Project coverage is 23.67%. Comparing base (abee03e) to head (a86edef).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
- Coverage   24.08%   23.67%   -0.42%     
==========================================
  Files         173      177       +4     
  Lines       15754    16040     +286     
==========================================
+ Hits         3795     3798       +3     
- Misses      11675    11958     +283     
  Partials      284      284
Flag Coverage Δ
backend_integration 8.98% <3.67%> (-0.19%) ⬇️
backend_ut 26.17% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abee03e...a86edef. Read the comment docs.

@rleungx
Copy link
Member Author

rleungx commented Feb 28, 2024

@mornyx PTAL

@baurine
Copy link
Collaborator

baurine commented Mar 8, 2024

I will help review next week.

@rleungx , can you elaborate the PR when you're free, for example, how to build the dev env so I can test the PR, attach some screenshots. thanks~

@baurine
Copy link
Collaborator

baurine commented Mar 14, 2024 •
edited
Loading

test:

tiup playground nightly --pd.mode ms --pd.api 1 --pd.scheduling 1 --pd.tso 1 --pd.rm 0 --kv 3 --tiflash 0 --db 1

baurine
baurine reviewed Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@baurine baurine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code LGTM, let me test the compatibility with old version cluster

baurine
baurine reviewed Mar 14, 2024
View reviewed changes
pkg/utils/topology/tso.go Outdated Show resolved Hide resolved
@baurine
Copy link
Collaborator

baurine commented Mar 14, 2024

screenshot:

image

image

image

image

@baurine
Copy link
Collaborator

baurine commented Mar 14, 2024

test compatibility, connect with tidb 7.5.0 cluster, reports following error in the cluster info page:

img_v3_028v_c0ee8a24-2ba7-435b-8271-f41b0e31a16g

@baurine
Copy link
Collaborator

baurine commented Mar 14, 2024 •
edited
Loading

fix the following errors in commit: c0d1625 , after cherry-pick this commit, this PR is able to be approved.

@rleungx rleungx force-pushed the add-backend-for-ms branch from 1d68134 to a86edef Compare March 14, 2024 05:20
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 14, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-14 05:41:07.228163195 +0000 UTC m=+923294.250409579: ☑️ agreed by baurine.

@ti-chi-bot ti-chi-bot bot added the approved label Mar 14, 2024
@baurine baurine merged commit 68517df into pingcap:master Mar 14, 2024
13 of 15 checks passed
@rleungx rleungx deleted the add-backend-for-ms branch March 14, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baurine baurine baurine approved these changes

@Renkai Renkai Awaiting requested review from Renkai

Assignees
No one assigned
Labels
approved area/frontend lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rleungx @CLAassistant @baurine